Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

other: Comment out cross ARM targets #376

Merged
merged 1 commit into from
Dec 26, 2020

Conversation

ClementTsang
Copy link
Owner

Description

A description of the change and what it does. If relevant, please provide screenshots of what results from the change:

Comment out some linkers set in .config/cargo.toml for ARM targets.

Issue

If applicable, what issue does this address?

Closes: #

Type of change

Remove the irrelevant ones:

  • Other (something else - please specify)

Test methodology

If relevant, please state how this was tested:

Furthermore, please tick which platforms this change was tested on:

  • Windows
  • macOS
  • Linux

If relevant, all of these platforms should be tested.

Checklist

If relevant, ensure the following have been met:

  • Change has been tested to work, and does not cause new breakage unless intended
  • Code has been self-reviewed
  • Documentation has been added/updated if needed (README, help menu, etc.)
  • Passes CI pipeline (clippy check and cargo test check)
  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • No merge conflicts arise from the change

Other information

Provide any other relevant information to this change:

@ClementTsang ClementTsang merged commit c864f53 into master Dec 26, 2020
@ClementTsang ClementTsang deleted the comment_out_cross_arm_targets branch December 26, 2020 21:24
@heitbaum
Copy link

@ClementTsang please include this commit in your next release. To compile https://github.com/LibreELEC/LibreELEC.tv for Odroid N2
PROJECT=Amlogic ARCH=aarch64 DEVICE=AMLGX UBOOT_SYSTEM=odroid-n2 scripts/create_addon system-tools
it is required

@heitbaum heitbaum mentioned this pull request Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants