Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix netip.Addr pointer panic #1029

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Fix netip.Addr pointer panic #1029

merged 1 commit into from
Jul 20, 2023

Conversation

anjmao
Copy link
Contributor

@anjmao anjmao commented Jul 14, 2023

Summary

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added

@CLAassistant
Copy link

CLAassistant commented Jul 14, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@anjmao
Copy link
Contributor Author

anjmao commented Jul 17, 2023

Found one more issue. Array(IPv4) will not work since Row() any returns net.IP type.

@anjmao
Copy link
Contributor Author

anjmao commented Jul 18, 2023

@gingerwizard Hi, can we merge this fix for IPv4 type? Arrays and Tuples can be addressed later.

@jkaflik jkaflik self-assigned this Jul 20, 2023
@jkaflik jkaflik merged commit 050f670 into ClickHouse:main Jul 20, 2023
@jkaflik jkaflik mentioned this pull request Aug 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jkaflik jkaflik

Labels
bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anjmao @CLAassistant @jkaflik