Fix insertion of empty map into JSON column by using _dummy subcolumn #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leonardo Di Donato <[email protected]>
Signed-off-by: Leonardo Di Donato <[email protected]>
|
|
|
Nice! Thanks @leodido |
jkaflik
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1113 (in the issue the code to reproduce it)
This PR correctly handles the inputting of an empty map,
by creating an empty tuple to ensure the subcolumns protocol is happy.
The
_dummykey is a ClickHouse internal name for an empty tuple subcolumn. In fact, it is the same key it gets used when inputting{}.With this PR,
inputting
map[string]any{}from Go has the same effect asINSERT INTO single_json_type_table VALUES ('{}');.In @jkaflik's PR #1115 there are other evaluated fixes/solutions.
Checklist
Delete items not relevant to your PR: