-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DateTime64 range to actual supported range per ClickHouse documentation #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Philipp Schreiber seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
@phil-schreiber thanks! Do you mind adding a test case? |
jkaflik
changed the title
fix datetime64 range to actual supported range per clickhouse docu
Fix DateTime64 range to actual supported range per ClickHouse documentation
Nov 29, 2023
jkaflik
approved these changes
Nov 29, 2023
TylerHelmuth
referenced
this pull request
in open-telemetry/opentelemetry-collector-contrib
Dec 13, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/ClickHouse/clickhouse-go/v2](https://togithub.com/ClickHouse/clickhouse-go) | require | minor | `v2.15.0` -> `v2.16.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>ClickHouse/clickhouse-go (github.com/ClickHouse/clickhouse-go/v2)</summary> ### [`v2.16.0`](https://togithub.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2160-2023-12-01----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---) [Compare Source](https://togithub.com/ClickHouse/clickhouse-go/compare/v2.15.0...v2.16.0) #### What's Changed ##### Enhancements 🎉 - Add sql.Valuer support for all types by [@​deankarn](https://togithub.com/deankarn) in [https://github.com/ClickHouse/clickhouse-go/pull/1144](https://togithub.com/ClickHouse/clickhouse-go/pull/1144) ##### Fixes 🐛 - Fix DateTime64 range to actual supported range per ClickHouse documentation by [@​phil-schreiber](https://togithub.com/phil-schreiber) in [https://github.com/ClickHouse/clickhouse-go/pull/1148](https://togithub.com/ClickHouse/clickhouse-go/pull/1148) #### New Contributors - [@​phil-schreiber](https://togithub.com/phil-schreiber) made their first contribution in [https://github.com/ClickHouse/clickhouse-go/pull/1148](https://togithub.com/ClickHouse/clickhouse-go/pull/1148) - [@​deankarn](https://togithub.com/deankarn) made their first contribution in [https://github.com/ClickHouse/clickhouse-go/pull/1144](https://togithub.com/ClickHouse/clickhouse-go/pull/1144) **Full Changelog**: ClickHouse/clickhouse-go@v2.15.0...v2.16.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44Ny4yIiwidXBkYXRlZEluVmVyIjoiMzcuODcuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <[email protected]>
cparkins
referenced
this pull request
in AmadeusITGroup/opentelemetry-collector-contrib
Jan 10, 2024
…-telemetry#29809) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/ClickHouse/clickhouse-go/v2](https://togithub.com/ClickHouse/clickhouse-go) | require | minor | `v2.15.0` -> `v2.16.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>ClickHouse/clickhouse-go (github.com/ClickHouse/clickhouse-go/v2)</summary> ### [`v2.16.0`](https://togithub.com/ClickHouse/clickhouse-go/blob/HEAD/CHANGELOG.md#v2160-2023-12-01----Release-notes-generated-using-configuration-in-githubreleaseyml-at-main---) [Compare Source](https://togithub.com/ClickHouse/clickhouse-go/compare/v2.15.0...v2.16.0) #### What's Changed ##### Enhancements 🎉 - Add sql.Valuer support for all types by [@&open-telemetry#8203;deankarn](https://togithub.com/deankarn) in [https://github.com/ClickHouse/clickhouse-go/pull/1144](https://togithub.com/ClickHouse/clickhouse-go/pull/1144) ##### Fixes 🐛 - Fix DateTime64 range to actual supported range per ClickHouse documentation by [@&open-telemetry#8203;phil-schreiber](https://togithub.com/phil-schreiber) in [https://github.com/ClickHouse/clickhouse-go/pull/1148](https://togithub.com/ClickHouse/clickhouse-go/pull/1148) #### New Contributors - [@&open-telemetry#8203;phil-schreiber](https://togithub.com/phil-schreiber) made their first contribution in [https://github.com/ClickHouse/clickhouse-go/pull/1148](https://togithub.com/ClickHouse/clickhouse-go/pull/1148) - [@&open-telemetry#8203;deankarn](https://togithub.com/deankarn) made their first contribution in [https://github.com/ClickHouse/clickhouse-go/pull/1144](https://togithub.com/ClickHouse/clickhouse-go/pull/1144) **Full Changelog**: ClickHouse/clickhouse-go@v2.15.0...v2.16.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44Ny4yIiwidXBkYXRlZEluVmVyIjoiMzcuODcuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The clickhouse documentation specifies a range starting from date
1900-01-01 00:00:00
and ending in2262-04-11 23:47:16
for Datetime64(9) precisionSee here
Checklist
Delete items not relevant to your PR: