Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default implementation of column.IterableOrderedMap #1417

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

earwin
Copy link
Contributor

@earwin earwin commented Oct 9, 2024

Summary

As discussed in #1402: most of column.IterableOrderedMap use cases can be covered by a simple default implementation.
This pull request aims to provide the implementation.

@CLAassistant
Copy link

CLAassistant commented Oct 9, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@jkaflik jkaflik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @earwin ! Could you provide a minimal unit test for your implementation?

@earwin
Copy link
Contributor Author

earwin commented Oct 15, 2024

@jkaflik
I had examples modified so they use my impl instead of locally defined, so we already had an e2e test in place.
And there's very little actual code being added.
But if it helps, by all means, there you are : )

@jkaflik jkaflik merged commit dc13f5d into ClickHouse:main Oct 16, 2024
16 checks passed
@earwin earwin deleted the default-orderedmap branch October 16, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants