Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align timezone handling with spec #766

Merged
merged 10 commits into from
Sep 27, 2022
Merged

Align timezone handling with spec #766

merged 10 commits into from
Sep 27, 2022

Conversation

gingerwizard
Copy link
Collaborator

Aligns datetime,datetime64, date and date32 with client specifications on how we plan to handle timezones.

Specifically,

  1. if parsing strings for datetime, datetime64 or dates we assume the locale is Local (i.e. the client) if not specified in the string.
  2. The server (or column tz) is used for datetime and datetime64 rendering. For date/date32, these have no tz info in the server. For now, they will be rendered as UTC - I believe this is consistent with the clickhouse-client.
  3. Addresses bind when no location is set

closes #759
closes #690
closes #719

@mshustov

@gingerwizard gingerwizard merged commit 14a7f0f into main Sep 27, 2022
@gingerwizard gingerwizard deleted the issue_690 branch September 28, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants