dont panic batch on send after invalid append

clickhouse.go

@@ -41,6 +41,7 @@ type (
 )
 
 var (
+	ErrBatchInvalid              = errors.New("clickhouse: batch is invalid. check appended data is correct")
 	ErrBatchAlreadySent          = errors.New("clickhouse: batch has already been sent")
 	ErrAcquireConnTimeout        = errors.New("clickhouse: acquire conn timeout. you can increase the number of max open conn or the dial timeout")
 	ErrUnsupportedServerRevision = errors.New("clickhouse: unsupported server revision")

conn_batch.go

@@ -20,6 +20,7 @@ package clickhouse
 import (
 	"context"
 	"fmt"
+	"github.com/pkg/errors"
 	"os"
 	"regexp"
 	"strings"
@@ -105,6 +106,7 @@ func (b *batch) Append(v ...interface{}) error {
 	}
 	//
 	if err := b.block.Append(v...); err != nil {
+		b.err = errors.Wrap(ErrBatchInvalid, err.Error())
 		b.release(err)
 		return err
 	}

tests/issues/798_test.go

@@ -0,0 +1,53 @@
+package issues
+
+import (
+	"context"
+	"github.com/ClickHouse/clickhouse-go/v2"
+	clickhouse_tests "github.com/ClickHouse/clickhouse-go/v2/tests"
+	"github.com/stretchr/testify/require"
+	"testing"
+)
+
+func Test798(t *testing.T) {
+	var (
+		conn, err = clickhouse_tests.GetConnection("issues", clickhouse.Settings{
+			"max_execution_time": 60,
+		}, nil, &clickhouse.Compression{
+			Method: clickhouse.CompressionLZ4,
+		})
+	)
+	ctx := context.Background()
+	require.NoError(t, err)
+	const ddl = `
+			CREATE TABLE test_issue_798 (
+				  Col1 Bool
+				, Col2 Bool
+				, Col3 Array(Bool)
+			) Engine MergeTree() ORDER BY tuple()
+		`
+	defer func() {
+		conn.Exec(ctx, "DROP TABLE IF EXISTS test_issue_798")
+	}()
+	require.NoError(t, conn.Exec(ctx, ddl))
+	batch, err := conn.PrepareBatch(ctx, "INSERT INTO test_issue_798")
+	require.NoError(t, err)
+	require.NoError(t, batch.Append(true, false, []bool{true, false, true}))
+	require.NoError(t, batch.Send())
+	// test resend
+	require.ErrorIs(t, batch.Send(), clickhouse.ErrBatchAlreadySent)
+	batch, err = conn.PrepareBatch(ctx, "INSERT INTO test_issue_798")
+	require.NoError(t, err)
+	// test empty batch
+	require.NoError(t, batch.Send())
+	batch, err = conn.PrepareBatch(ctx, "INSERT INTO test_issue_798")
+	// append invalid batch
+	require.Error(t, batch.Append("true", false, []bool{true, false, true}))
+	// send invalid batch
+	require.ErrorIs(t, batch.Flush(), clickhouse.ErrBatchInvalid)
+	require.ErrorIs(t, batch.Send(), clickhouse.ErrBatchInvalid)
+	// test append, send, append
+	batch, err = conn.PrepareBatch(ctx, "INSERT INTO test_issue_798")
+	require.NoError(t, batch.Append(true, false, []bool{true, false, true}))
+	require.NoError(t, batch.Send())
+	require.ErrorIs(t, batch.Append(true, false, []bool{true, false, true}), clickhouse.ErrBatchAlreadySent)
+}