Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support customized "url path" in http connection #938

Merged
merged 3 commits into from
Mar 27, 2023

Conversation

crisismaple
Copy link
Contributor

Summary

add a new HttpUrlPath field in Clickhouse.Options to support customize URL path used by HTTP connection (#937)

@CLAassistant
Copy link

CLAassistant commented Mar 20, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@jkaflik jkaflik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks ok. Let's introduce a minimal test that verifies if we can connect to CH with HTTP via some proxy.

This could be an additional nginx container that does a reverse proxy.

WDYT?

@crisismaple
Copy link
Contributor Author

This change looks ok. Let's introduce a minimal test that verifies if we can connect to CH with HTTP via some proxy.

This could be an additional nginx container that does a reverse proxy.

WDYT?

sure, I will add std test case for that ;)

@crisismaple
Copy link
Contributor Author

@jkaflik I just pushed a new iteration, please help to review it ;)

@jkaflik
Copy link
Contributor

jkaflik commented Mar 24, 2023

@crisismaple that's great! I will release it today

@jkaflik jkaflik merged commit f09a004 into ClickHouse:main Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants