Tuple scan respects both value and pointer variable #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisismaple
changed the title
ptr flagtuple scan logic respect the ptr flag
|
@crisismaple could you resolve the conflict? |
crisismaple
force-pushed
the
tuple_pointer
branch
from
7078c97
to
152935e
Compare
Sure, just update the PR |
jkaflik
changed the title
tuple scan logic respect the ptr flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Now scan result of
tupletyped column is*[]interface{}/*map[string]interface{}instead of[]interface{}/map[string]interface{}, sincetupletype is not allowed to be nullable in CH, the destination type oftuplecolumns should not be pointer.Checklist
Delete items not relevant to your PR: