Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding query_id to V1 client #1699

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Adding query_id to V1 client #1699

merged 2 commits into from
Jun 20, 2024

Conversation

Paultagoras
Copy link
Contributor

Summary

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

Copy link
Contributor

@mzitnik mzitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a real test that do actual work
We can set the query_id and check if we get the same one on the response

@Paultagoras Paultagoras requested a review from mzitnik June 20, 2024 13:10
Copy link
Contributor

@mzitnik mzitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but let also add it in our new API as separate PR

@Paultagoras Paultagoras merged commit c30c346 into main Jun 20, 2024
8 of 9 checks passed
@Paultagoras Paultagoras deleted the add-query-id-summary branch June 20, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: Expose "queryId" field from "ClickHouseHttpResponse" to "ClickHouseResponse"
2 participants