[client-v2] Retries on failures #1768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
chernser
requested review from
mzitnik and
Paultagoras
and removed request for
mzitnik and
Paultagoras
mzitnik
approved these changes
Aug 28, 2024
| } | ||
|
|
||
| if (!userConfig.containsKey("client_network_buffer_size")) { | ||
| if (!configuration.containsKey("client_network_buffer_size")) { | ||
| setClientNetworkBufferSize(8192); |
| throw new ClientException("Failed to get response", e); | ||
| } | ||
| LOG.warn("Failed to get response. Retrying.", e); | ||
| } catch ( NoHttpResponseException | ConnectionRequestTimeoutException | ConnectTimeoutException e) { |
There was a problem hiding this comment.
Is it a duplicated code? (i see in other inserts as well)
There was a problem hiding this comment.
yes. I left it as duplicate because handling it in dedicated method would not be much shorter. I will review this code later if it can be extracted to a single method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1692
Checklist
Delete items not relevant to your PR: