Pre 0.6.4 Updates #1773
Pre 0.6.4 Updates #1773
Conversation
| ## 0.6.4 | ||
|
|
||
| ### Important | ||
| - Following components will be deprecated and archived in next release: |
There was a problem hiding this comment.
Have we confirmed the removal in the next release? If no, I'd move the deprecation warning at the top to ensure it's visible to everyone reading the file
There was a problem hiding this comment.
Moved to deprecations section.
| - Following components will be deprecated and archived in next release: | ||
| - clickhouse-cli-client | ||
| - clickhouse-grpc-client | ||
| - No more builds for non-lts Java versions - no more Java 9 release builds. |
There was a problem hiding this comment.
Isn't it a breaking change for users with the old Java version? If so, should we tag the release as 0.7.0?
There was a problem hiding this comment.
Discussed. It will be in deprecations warning and will be removed in 0.7.0 release.
CHANGELOG.md
Outdated
| (https://github.com/ClickHouse/clickhouse-java/pull/1771) | ||
| - com.clickhouse.client.config.ClickHouseClientOption#CONNECTION_TTL - to configure connection time-to-live | ||
| - com.clickhouse.client.http.config.ClickHouseHttpOption#KEEP_ALIVE_TIMEOUT - to configure keep-alive timeout | ||
| - com.clickhouse.client.http.config.ClickHouseHttpOption#CONNECTION_REUSE_STRATEGY - to configure how connection |
There was a problem hiding this comment.
The setting name is self-descriptive. We'd rather focus on the meaning of the setting and possible configuration value. You can even use the existing comments from javadoc
CHANGELOG.md
Outdated
| Select FIFO to reuse connections evenly or LIFO (default) to reuse the most recently active connections. | ||
| - [Client-V2] All operations are now executed in calling thread to avoid extra threads creation. | ||
| Async operations can be enabled by `com.clickhouse.client.api.Client.Builder.useAsyncRequests` (https://github.com/ClickHouse/clickhouse-java/pull/1767) | ||
| - [Client-V2] Spring Demo Service as usage example (https://github.com/ClickHouse/clickhouse-java/pull/1765) |
There was a problem hiding this comment.
Should we group the code and docs changes into relevant sections? it would help to skim through the file
There was a problem hiding this comment.
Moved to documentation section.
|
Summary