Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[client-v2] Fix compression issue when concurrent requests #1791

Merged
merged 1 commit into from
Aug 26, 2024
Merged

[client-v2] Fix compression issue when concurrent requests #1791

merged 1 commit into from
Aug 26, 2024

Conversation

chernser
Copy link
Contributor

@chernser chernser commented Aug 26, 2024 •
edited
Loading

Summary

com.clickhouse.client.api.internal.ClickHouseLZ4InputStream had an optimization - header buffer, but it was static and shared thru all instances. This PR fixes this.

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@chernser chernser added this to the 0.6.5 milestone Aug 26, 2024
@chernser chernser requested a review from Paultagoras August 26, 2024 21:00
@chernser chernser merged commit 762d78a into main Aug 26, 2024
57 of 59 checks passed
@chernser chernser deleted the fix_compression_issue branch August 26, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Paultagoras Paultagoras Paultagoras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.5
Development

Successfully merging this pull request may close these issues.
2 participants
@chernser @Paultagoras