Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[client-v2] Tests and Fixes in scope of SerDe #1830

Merged
merged 7 commits into from
Sep 25, 2024
Merged

Conversation

chernser
Copy link
Contributor

@chernser chernser commented Sep 19, 2024

Summary

  • Added more data type tests
  • Fixed read error from response
  • Added possibility to register class against different tables.

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@chernser chernser marked this pull request as ready for review September 24, 2024 17:16
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
60.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@chernser
Copy link
Contributor Author

I've found that reading AggregationFunction seems has some bug in reading code what causes reading far after real stream ended. I will work in this issue later. Currently it is only for writing.

@chernser chernser merged commit 5ceb43d into main Sep 25, 2024
59 of 60 checks passed
@chernser chernser deleted the clientv2_pojo_serde_tests branch September 25, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants