Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[client-v2] removed float/double overflow check #1955

Merged
merged 1 commit into from
Nov 19, 2024
Merged

[client-v2] removed float/double overflow check #1955

merged 1 commit into from
Nov 19, 2024

Conversation

chernser
Copy link
Contributor

@chernser chernser commented Nov 19, 2024 •
edited
Loading

Summary

Closes: #1954

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
24.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@chernser chernser merged commit ccd24bf into main Nov 19, 2024
60 of 61 checks passed
@chernser chernser deleted the v2_fix_number_conversion branch November 19, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Paultagoras Paultagoras Paultagoras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[client-v2] Impossible to get float value by getFloat() because of incorrect overflow check
2 participants
@chernser @Paultagoras