Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[client-v2] Fixes flags for compression #1980

Merged
merged 2 commits into from
Nov 26, 2024
Merged

[client-v2] Fixes flags for compression #1980

merged 2 commits into from
Nov 26, 2024

Conversation

chernser
Copy link
Contributor

@chernser chernser commented Nov 25, 2024 •
edited
Loading

Summary

Closes: #1958

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@chernser chernser merged commit 5ea0e26 into main Nov 26, 2024
61 checks passed
@chernser chernser deleted the v2_fix_client_compression branch November 26, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Paultagoras Paultagoras Paultagoras approved these changes

@mzitnik mzitnik Awaiting requested review from mzitnik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[client-v2] Option 'compressClientRequest' is never set
2 participants
@chernser @Paultagoras