[client-v2] V2 implement writer api #2034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzitnik
approved these changes
Dec 29, 2024
| settings.getInputStreamCopyBufferSize(); | ||
|
|
||
| if (writeBufferSize <= 0) { | ||
| throw new IllegalArgumentException("Buffer size must be greater than 0"); |
There was a problem hiding this comment.
Why we can not do that in InsertSettings and throw the exception from there?
There was a problem hiding this comment.
this value can be set by two method setInputStreamCopyBufferSize and setOption and here I'm doing specific calculation.
One more reason - I keep validation here because it is implementation specific code for this operation. InsertSettings should not be aware of this validation because they may be used for other purposes.
| @@ -104,7 +104,7 @@ public enum ClientConfigProperties { | |||
|
|
|||
| QUERY_ID("query_id"), // actually a server setting, but has client effect too | |||
|
|
|||
| CLIENT_NETWORK_BUFFER_SIZE("client_network_buffer_size"), | |||
| CLIENT_NETWORK_BUFFER_SIZE("client_network_buffer_size", "8192"), | |||
There was a problem hiding this comment.
lets extract it to a const
There was a problem hiding this comment.
Done -> com.clickhouse.client.api.Client.Builder#DEFAULT_BUFFER_SIZE
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements new Writer style API for insert operations.
Writer API intended to work:
Main change:
com.clickhouse.client.api.Client#insert(java.lang.String, com.clickhouse.client.api.DataStreamWriter, com.clickhouse.data.ClickHouseFormat, com.clickhouse.client.api.insert.InsertSettings)- intriduces ability to use data stream writer that can control how to write data.Current PR introduces two new experimental classes:
com.clickhouse.client.api.data_formats.RowBinaryFormatWriter- Intend to simplify writing RowBinary encoded datacom.clickhouse.client.api.data_formats.RowBinaryFormatSerializer- very low-level serializer for RowBinary encoding. For very advanced users.Checklist
Delete items not relevant to your PR: