Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding some duration timers #2104

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Adding some duration timers #2104

merged 1 commit into from
Jan 22, 2025

Conversation

Paultagoras
Copy link
Contributor

@Paultagoras Paultagoras commented Jan 22, 2025

Summary

  • Adding times to help debug future network issues

Closes #1994

Checklist

Delete items not relevant to your PR:

  • Closes #
  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@Paultagoras Paultagoras requested a review from chernser January 22, 2025 18:30
@Paultagoras Paultagoras self-assigned this Jan 22, 2025
@Paultagoras
Copy link
Contributor Author

I didn't end up adding InputStream.available() because it only references bytes without blocking (rather than an actual estimate of total bytes)

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
60.5% Coverage on New Code (required ≥ 80%)
4.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@Paultagoras Paultagoras merged commit 0992132 into main Jan 22, 2025
29 of 30 checks passed
@Paultagoras Paultagoras deleted the adding-network-debugging branch January 22, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[client-v2] Connection Disruption Issues (Timeout, Reset by Peer, No Response)
2 participants