Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[client-v2] Fix support in ClickHouseBinaryFormatReader for SimpleAggregateValue #2128

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Am-phi
Copy link
Contributor

@Am-phi Am-phi commented Feb 1, 2025

Summary

This is a response to #2127 which is complementary to #2022. I'm however concerned by my solution as it is, it may be contested or refused. The solution proposed here is by adding a specific check for each operation that gets the dataType to check if it's a simpleAggregateFunction, and if it's the case take the nested column datatype. Maybe a modification of the ClickhouseColumn implementation could be cleaner but its scope is above my understanding at this moment.

Closes #2127

Checklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Client-v2] The newBinaryFormatReader can't correctly read SimpleAggregate values
1 participant