[client-v2] Fix support in ClickHouseBinaryFormatReader for SimpleAggregateValue #2128
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a response to #2127 which is complementary to #2022. I'm however concerned by my solution as it is, it may be contested or refused. The solution proposed here is by adding a specific check for each operation that gets the dataType to check if it's a simpleAggregateFunction, and if it's the case take the nested column datatype. Maybe a modification of the ClickhouseColumn implementation could be cleaner but its scope is above my understanding at this moment.
Closes #2127
Checklist