Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Height and HeightRange option. #360

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Conversation

masterworgen
Copy link
Contributor

Pull Request Description

Summary

I have added two new tags to the library, <<Height number>> and <<HeightRange number>>, which allow users to set the height for individual rows and a range of rows respectively.

Changes Made

  1. <<Height number>> Tag: This tag sets the height for a specific row. When this tag is processed, the row height is adjusted according to the specified number.

    Example Usage:

    <<Height 20>>
    

    After processing, the row containing this tag will have a height of 20 units.

  2. <<HeightRange number>> Tag: This tag sets the height for a range of rows. When this tag is processed, the specified range of rows will have their heights set to the given number.

    Example Usage:

    <<HeightRange 30>>
    

    After processing, the rows in the specified range will each have a height of 30 units.

Detailed Implementation

  • The <<Height number>> tag parses the number and applies it to the height property of the targeted row.
  • The <<HeightRange number>> tag parses the number and applies it to the height property of the rows within the specified range.

These enhancements aim to provide more flexibility and control over row formatting in the library.

Thank you for considering this pull request. I believe these additions will greatly benefit users by providing more precise control over row heights.

@Pankraty Pankraty reopened this Jul 3, 2024
@Pankraty
Copy link
Member

Pankraty commented Jul 3, 2024

Please, add some tests - maybe something like this checking the new tags, or put a template with these tags into test/Templates folder and make a test like this.

Notice there are failing tests here.

@Pankraty Pankraty added this to the 0.2.11 milestone Jul 3, 2024
@masterworgen
Copy link
Contributor Author

Add and fix tests

tests/Templates/4D366000 Outdated Show resolved Hide resolved
@Pankraty Pankraty merged commit a428fa4 into ClosedXML:develop Jul 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants