Merge pull request #96 from Cloudshelf/node-version-is-build

Node version is build
Cloudshelf · Dec 31, 2024 · f41ab0c · f41ab0c
2 parents 84110be + a2c3455
commit f41ab0c
Show file tree

Hide file tree

Showing 7 changed files with 24 additions and 5 deletions.
diff --git a/.github/workflows/deployment_development.yml b/.github/workflows/deployment_development.yml
@@ -45,6 +45,11 @@ jobs:
             - name: Checkout
               uses: actions/checkout@v3
 
+            # Enforce node version
+            - uses: actions/setup-node@v4
+              with:
+                  node-version: 20.17.0
+
             # Create the first message on slack
             - name: Update status on slack
               id: slack

diff --git a/.github/workflows/deployment_production.yml b/.github/workflows/deployment_production.yml
@@ -45,6 +45,11 @@ jobs:
             - name: Checkout
               uses: actions/checkout@v3
 
+            # Enforce node version
+            - uses: actions/setup-node@v4
+              with:
+                  node-version: 20.17.0
+
             # Create the first message on slack
             - name: Update status on slack
               id: slack

diff --git a/package.json b/package.json
@@ -36,11 +36,11 @@
     "@apollo/client": "^3.8.1",
     "@apollo/server": "^4.10.0",
     "@aws-sdk/client-s3": "^3.637.0",
-    "@mikro-orm/cli": "^6.3.6",
-    "@mikro-orm/core": "^6.3.6",
-    "@mikro-orm/migrations": "^6.3.6",
+    "@mikro-orm/cli": "^6.3.13",
+    "@mikro-orm/core": "^6.3.13",
+    "@mikro-orm/migrations": "^6.3.13",
     "@mikro-orm/nestjs": "^6.0.2",
-    "@mikro-orm/postgresql": "^6.3.6",
+    "@mikro-orm/postgresql": "^6.3.13",
     "@mikro-orm/sql-highlighter": "^1.0.1",
     "@nestjs-shopify/auth": "^4.2.0",
     "@nestjs-shopify/core": "^3.3.0",

diff --git a/src/main.ts b/src/main.ts
@@ -33,6 +33,7 @@ async function bootstrap() {
         maxValueLength: 1250,
         async beforeSend(event: SentryEvent, hint?: EventHint): Promise<SentryEvent | null> {
             //Do some filtering here
+            console.log('Sentry before send', event);
             return event;
         },
     });

diff --git a/src/modules/data-ingestion/product.job.utils.ts b/src/modules/data-ingestion/product.job.utils.ts
@@ -130,6 +130,7 @@ export class ProductJobUtils {
         } catch (err: any) {
             logs?.error(`Error in product consumer scheduler.`);
             logs?.error(`err`, err);
+            throw err;
         }
     }
 }
diff --git a/src/modules/shopify/auth/no.oauth.cookie.exception.filter.ts b/src/modules/shopify/auth/no.oauth.cookie.exception.filter.ts
@@ -1,4 +1,4 @@
-import { ArgumentsHost, Catch, ExceptionFilter, HttpException, HttpStatus } from '@nestjs/common';
+import { ArgumentsHost, Catch, ExceptionFilter } from '@nestjs/common';
 import { ExtendedLogger } from '../../../utils/ExtendedLogger';
 import { HtmlUtils } from '../../../utils/HtmlUtils';
 import { Request, Response } from 'express';
@@ -9,6 +9,8 @@ export class NoOAuthCookieExceptionFilter implements ExceptionFilter {
     catch(exception: unknown, host: ArgumentsHost) {
         this.logger.debug(`In NoOAuthCookieExceptionFilter`);
         const ctx = host.switchToHttp();
+        this.logger.debug('ctx type', (ctx as any).contextType ?? 'unknown');
+        this.logger.debug('exception being filtered', exception);
         if ((ctx as any).contextType && (ctx as any).contextType === 'graphql') {
             //do nothing as we want to see the GQL errors in the manager, so we rethrow
             this.logger.debug(`graphql context, skipping`);
@@ -28,6 +30,7 @@ export class NoOAuthCookieExceptionFilter implements ExceptionFilter {
             return;
         }
 
+        this.logger.debug(`rethorwing`);
         throw exception;
     }
 }
diff --git a/src/modules/shopify/webhooks/bulk.operation.finish.webhook.handler.ts b/src/modules/shopify/webhooks/bulk.operation.finish.webhook.handler.ts
@@ -52,12 +52,16 @@ export class BulkOperationFinishedWebhookHandler extends ShopifyWebhookHandler<u
         if (!bulkOp) {
             this.logger.log('bulkOpComplete webhook referenced unknown bulkOp');
             return;
+        } else {
+            this.logger.debug(`Loaded bulkop from database`, bulkOp);
         }
 
         const retailer = await this.retailerService.getByDomain(domain);
         if (!retailer) {
             this.logger.debug('Cannot get retailer for domain ' + domain);
             return;
+        } else {
+            this.logger.debug(`Loaded retailer from database`, retailer);
         }
 
         bulkOp = await this.bulkOperationService.updateFromShopify(retailer, bulkOp);