Fixes

.github/workflows/deployment_development.yml

@@ -13,12 +13,12 @@ jobs:
         steps:
             # Checkout branch
             - name: Checkout
-              uses: actions/checkout@v3
+              uses: actions/checkout@v4
 
             # Enforce node version
             - uses: actions/setup-node@v4
               with:
-                  node-version: 20.17.0
+                  node-version: 20
 
             # Versioning
             - name: Perform Versioning
@@ -43,12 +43,12 @@ jobs:
             contents: read
         steps:
             - name: Checkout
-              uses: actions/checkout@v3
+              uses: actions/checkout@v4
 
             # Enforce node version
             - uses: actions/setup-node@v4
               with:
-                  node-version: 20.17.0
+                  node-version: 20
 
             # Create the first message on slack
             - name: Update status on slack

.github/workflows/deployment_production.yml

@@ -13,12 +13,12 @@ jobs:
         steps:
             # Checkout branch
             - name: Checkout
-              uses: actions/checkout@v3
+              uses: actions/checkout@v4
 
             # Enforce node version
             - uses: actions/setup-node@v4
               with:
-                  node-version: 20.17.0
+                  node-version: 20
 
             # Versioning
             - name: Perform Versioning
@@ -43,12 +43,12 @@ jobs:
             contents: read
         steps:
             - name: Checkout
-              uses: actions/checkout@v3
+              uses: actions/checkout@v4
 
             # Enforce node version
             - uses: actions/setup-node@v4
               with:
-                  node-version: 20.17.0
+                  node-version: 20
 
             # Create the first message on slack
             - name: Update status on slack

Dockerfile

@@ -1,4 +1,4 @@
-FROM node:18-alpine as builder
+FROM node:20-alpine as builder
 
 WORKDIR /usr/src/app
 COPY package.json tsconfig.json package-lock.json .npmrc nest-cli.json tsconfig.build.json ./

src/modules/apm/sentry.exception.filter.ts

@@ -1,21 +1,27 @@
 import { ArgumentsHost, Catch, HttpServer } from '@nestjs/common';
 import { AbstractHttpAdapter, BaseExceptionFilter } from '@nestjs/core';
 import * as Sentry from '@sentry/node';
+import { ExtendedLogger } from '../../utils/ExtendedLogger';
 
 @Catch()
 export class SentryFilter extends BaseExceptionFilter {
+    readonly logger = new ExtendedLogger('SentryFilter');
     handleUnknownError(
         exception: any,
         host: ArgumentsHost,
         applicationRef: HttpServer<any, any> | AbstractHttpAdapter<any, any, any>,
     ): void {
+        this.logger.debug(`In SentryFilter`);
+        this.logger.debug(`sending exception to sentry`, JSON.stringify(exception));
         Sentry.captureException(exception);
 
         if ((host as any).contextType && (host as any).contextType === 'graphql') {
             //do nothing as we want to see the GQL errors in the manager
+            this.logger.debug(`doing nothing so we see the errors passed along to the gql request`);
         } else {
             //do the normal error stuff, so that we return the http error codes if it was a http request
-            super.handleUnknownError(exception, host, applicationRef);
+            this.logger.debug(`calling super`);
+            return super.handleUnknownError(exception, host, applicationRef);
         }
     }
 }

src/modules/shopify/webhooks/bulk.operation.finish.webhook.handler.ts

@@ -53,15 +53,15 @@ export class BulkOperationFinishedWebhookHandler extends ShopifyWebhookHandler<u
             this.logger.log('bulkOpComplete webhook referenced unknown bulkOp');
             return;
         } else {
-            this.logger.debug(`Loaded bulkop from database`, bulkOp);
+            this.logger.debug(`Loaded bulkop from database`, JSON.stringify(bulkOp));
         }
 
         const retailer = await this.retailerService.getByDomain(domain);
         if (!retailer) {
             this.logger.debug('Cannot get retailer for domain ' + domain);
             return;
         } else {
-            this.logger.debug(`Loaded retailer from database`, retailer);
+            this.logger.debug(`Loaded retailer from database`, JSON.stringify(retailer));
         }
 
         bulkOp = await this.bulkOperationService.updateFromShopify(retailer, bulkOp);