-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content-Security-Policy: add strict csp headers and use a nonce #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helps in Google Indexing, as otherwise it treats /gallery and /gallery?img=index as different pages
bhavberi
approved these changes
Oct 4, 2024
Dileepadari
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, testing with different components done, can be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need for Changes
unsafe-inline
styles andbasically have no CSP in place.
According to nextjs docs it is recommended to add these headers to the middleware and wherever
needed (when external scripts or inline scripts are being called), add the nonce instead
to uniquely generate a nonce everytime the page loads.
addind nonce to the ThemeRegistry using aa cache provider. (Update: We are having to use
unsafe-inline
because some MUI components use inline styles (mui github: issues/19938), we will remove this if it gets fixed upstream sometime).Changes
ThemeRegistry
style tag, and the subsequentCacheProvider
to cache it out.*.iiit.ac.in
, as a white list to<iframe>
as long as it is being displayed in the iiit website.Todo