-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Description & Summary errors #1242
Comments
I have been thinking abut this lately, but my thoughts have been towards encouraging people to write both the tweetable description and to do a longer summary, the new |
I think the description not having a full stop a the end is probably something we can live without, the summary though I'm don't think I agree with. |
I like the idea of short summaries but I don't see how ending it in a period changes anything. And as we know well what typically happens is people are unaware of this and they submit a spec with this as a single issue, which just isn't worth any of our time to deal with. |
@Keithbsmiley Good points. To shed some context on the check, it was introduced before the linting process would leverage xcodebuild, so at the time ensuring the correctness of the podspec was an error prone and tricky process. In this regard it helped to fight some contributors which just wanted to use a lib would submit a very messy spec. However the primary reason to introduce the check was to avoid to add normalization logic in clients (I don't like when the search results are not consistent - either from the command line or from a website). It also served as an experiment to test wether a strict approach to validation was feasible. I was expecting a strong backslash which didn't materialize even though some complaints were expressed; as @alloy never expressed to be against it, I just left it there. This test gave me the confidence to introduce the version-tag checks for git sources, as I noticed that the community would accept them as they are already used to a benevolent dictator (Apple). I don't have strong feelings about it, so if you guys think that it should go, just let me know. |
I'm inclined to believe that the further we get with automation, the less friction this will be. At the minute the worst affected are the ones most likely to get hit anyway; new people, because they can't go through With luck & maybe sending @alloy some booze we will get the auth that means this sort of problem isn't an issue. Till then my vote is on keeping the punctuation. I dunno if we allow |
I think the punctuation check can go. |
I love a democracy 🍻 Yeah, it's cool with me. |
Adding Intercom podspec
I think the errors such as:
Should be removed from CocoaPods. I think all these do is make people spend unnecessary brain cycles on something that is really a non issue. If we wanted to impose some sort of stylistic constraints I think time would be better spent with the order of attributes in specs not just whether or not some fields end with a period. What are your thoughts?
The text was updated successfully, but these errors were encountered: