-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved search #177
Comments
It's very nice! About github: maybe better to not include watchers and forks by default and only include this info by calling search command with specific flag? |
- colors - description wrap - GitHub watchers and followers
Indeed, it's very nice! But, I agree with Victor that we hold probably not enable the github info by default, as it is not essential information and obviously adds lag due to each network connection, which you will not want when trying multiple searches. It’s probably best to work on having an RC file asap so that the users can set their own defaults. |
@irrationalfab What do you think about always including the source, but make the stats part optional and changing the option name to |
@alloy this is a much cleaner approach. |
Btw, sorry for the push noise: I missed your comment and then I did a misstake that I realized only after push. |
Awesome! Please merge :)
Don’t worry man, it’s only a sign of someone doing work, I can’t have any problem with that ;) |
cool feature! thank you, @irrationalfab =) P.S. I like |
Hahah.. thanks, but you share part of the credit as it was inspired by your changes.
Actually it is |
According to wikipedia, ‘stats’ is the more often used form for ‘statistics’ in British English contexts. Statistics are: So For some unknown reason I find British English more charming :) |
Such a great explanation would convince even this guy. |
Note that I could very well be wrong, though ;) English is not my native language. |
@irrationalfab something went wrong on showing stats for
I will fix in a minute error with undefined method in error_report. But last error occur on creating nice error report and there are problem in lib/cocoapods/command.rb:62 (
I talked about colored output and repo stats) |
I run pod search not from directory with xcode project and it there was an error with reading podfile. Than I added check for existence of podfile. [#177]
here is details of problem mentioned in my previous post:
|
* origin: Erroneously deleted + on self.options [CocoaPods#177] @alloy's suggestions Revert .git behaviour and refactoring [fix] Support for dashes in GitHub repo and author [CocoaPods#177] Fix for GitHub repos missing final .git in the source [CocoaPods#177] Added --extended option Tweaks to regex and coloring [CocoaPods#177] Search command improvements * master:
- colors - description wrap - GitHub watchers and followers
I run pod search not from directory with xcode project and it there was an error with reading podfile. Than I added check for existence of podfile. [#177]
Inspired by the work of @yas375 I'm proposing some improvements to
pod search
Here is an example of what I have. Layout needs a bit of fine tuning.
The text was updated successfully, but these errors were encountered: