Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate a build phase that checks if Manifest.lock is in sync #946

Merged
merged 2 commits into from
Apr 8, 2013

Conversation

stigi
Copy link
Contributor

@stigi stigi commented Apr 7, 2013

As discussed on the mailing list.

This adds a build phase to the Applications target that checks if Pods/Manifest.lock is in sync with Podfile.lock. This helps to inform developers of updating their Pods when the Pods directory is not tracked by version control.

@stigi
Copy link
Contributor Author

stigi commented Apr 7, 2013

Started this PR of the 0.17.2 tag since master specs would fail all over me.

fabiopelosin added a commit that referenced this pull request Apr 8, 2013
Integrate a build phase that checks if Manifest.lock is in sync
@fabiopelosin fabiopelosin merged commit ab5f46c into CocoaPods:master Apr 8, 2013
@fabiopelosin
Copy link
Member

Solid work! Thanks.

@fabiopelosin
Copy link
Member

@stigi Please, let me know if you would like to be more involved with CP and would like to have commit access.

@stigi
Copy link
Contributor Author

stigi commented Apr 8, 2013

@irrationalfab will continue opening pull requests for now. Maybe at a later point in time. Thanks!

@fabiopelosin
Copy link
Member

For those reading this thread. Projects which already have been integrated with CocoaPods will not be upgraded automatically (for the time being). To implement this feature manually you can:

  1. Create for your target a shell script build phase named Check Pods Manifest.lock

  2. Configure it to run the following bash script:

    diff "${PODS_ROOT}/../Podfile.lock" "${PODS_ROOT}/Manifest.lock" > /dev/null
    if [[ $? != 0 ]] ; then
        cat << EOM
    Podfile.lock and Manifest.lock are not in sync.
    You might need to run a \`pod install\`.
    EOM
        exit 1
    fi
    

@nikolaykasyanov
Copy link
Contributor

Shouldn't message be changed from "You might need to run a pod install" to "You might need to run a pod install or to update your CocoaPods"? because CocoaPods version saved in lockfiles too.

@fabiopelosin
Copy link
Member

@Corristo 👍 Will you submit a pull request?

@nikolaykasyanov
Copy link
Contributor

@irrationalfab I'll try ;)

@fabiopelosin
Copy link
Member

@Corristo This is awesome! Please let me know if you need any support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants