[Linter] check frameworks attribute for invalid frameworks

[kylef]

As seen in https://github.com/Marxon13/Specs/commit/8ca38c40a2c8db87ce97b944417425623d18a737

• frameworks
• weak_frameworks
• libraries

A simple regex rule for detecting invalid names, such as with , and spaces etc.

[fabiopelosin]

This issue can be implemented by improving this two methods to check against a regex.

[squarefrog]

I would love to have a go at this, but I'm struggling to find the spec where these methods are tested. Can anyone point me in the right direction?

[fabiopelosin]

Hi @squarefrog... great to hear that!

The specs are here (by convention we name the test file like TESTED_CLASS_spec.rb and use the the same tree of the lib/cocoapods-core dir in the spec dir).

[squarefrog]

Thanks! I'll start on this tomorrow. I'll just add a simple regex to look for any non-alphanumeric. If this needs to change down the line (support symbols?), it should be easy to add new rules.

[fabiopelosin]

Sounds great!

[squarefrog]

Couldn't sleep ;)

Frameworks
AddressBook.framework
AddressBook!
AddressBook

Libraries
MyLibrary.a
MyLibrary.dylib
libMyLibrary
MyLibrary
Mylib2

Strikethroughs are strings filtered out by the validation.

[fabiopelosin]

@squarefrog in case any is missing... the tests of your patch should include all the cases that you presented above in #66 (comment)

[squarefrog]

Sure I can do that. Is there a way to check for passing cases? For example:

  it 'checks that acceptable frameworks do not raise messages' do
    @spec.frameworks = %w(MyLibrary Mylib2)
    message_should_not_include('framework', 'name')
  end

I know message_should_not_include does not exist but is there something similar.

[fabiopelosin]

You can create any function that would helpful as showcased in this spec

[squarefrog]

OK I'll see what I can come up with this weekend!