Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inhibit warnings per single pod #10

Merged
merged 3 commits into from
Apr 6, 2013

Conversation

supermarin
Copy link

Finally - thanks to @irrationalfab 's support :)

@coveralls
Copy link

Coverage remained the same when pulling 5991d05 on mneorr:inhibit_warnings into a139f44 on CocoaPods:master.

View Details

@@ -355,6 +373,7 @@ def set_platform(name, target = nil)
#
def store_pod(name, *requirements)
if requirements && !requirements.empty?
inhibit_warnings_if_asked(name, requirements)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternative name proposal: process_warning_inhibition

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or parse_inhibit_warnings ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

@coveralls
Copy link

Coverage remained the same when pulling 2d8a638 on mneorr:inhibit_warnings into a139f44 on CocoaPods:master.

View Details

@@ -392,8 +411,6 @@ def store_podspec(options = nil)

#-----------------------------------------------------------------------#

public
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see what you mean. The style that I was following is to open every new YARDoc group with the line to separate it, and then indicate the visibility regardless of the one of the previous group.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh.. got it. do you want me to force-push? 😸

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆

@coveralls
Copy link

Coverage remained the same when pulling 4966d05 on mneorr:inhibit_warnings into eb67003 on CocoaPods:master.

View Details

supermarin pushed a commit that referenced this pull request Apr 6, 2013
Inhibit warnings per single pod
@supermarin supermarin merged commit 17179bd into CocoaPods:master Apr 6, 2013
Ashton-W pushed a commit to Ashton-W/Core that referenced this pull request Nov 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants