[Podfile::DSL] Allow link_with targets to be passed as the arg list instead of an array #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstead of an array Also adds spec coverage to ensure backwards compatibility with the array style.
|
Looks good to me, can you add an entry to the CocoaPods/CocoaPods Changelog crediting yourself? |
|
Done. |
|
Awesome thanks! |
fabiopelosin
added a commit
that referenced
this pull request
Oct 11, 2013
[Podfile::DSL] Allow link_with targets to be passed as the arg list instead of an array
fabiopelosin
added a commit
to CocoaPods/CocoaPods
that referenced
this pull request
Oct 11, 2013
Update CHANGELOG.md for CocoaPods/Core#30
|
Is the old syntax for this included in |
|
No, we don't link with multiple targets there. |
Ashton-W
pushed a commit
to Ashton-W/Core
that referenced
this pull request
Nov 2, 2015
[Podfile::DSL] Allow link_with targets to be passed as the arg list instead of an array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seemed like it would be a nice API not to be required to wrap the target
list in an array explicitly. Hope you like it!