Added DNS_BLOCK_ASSERTIONS=1 to default Xcode release flags

[xslim]

No description provided.

[alloy]

Can you add a simple test for it? This way we ensure that in the future we don’t accidentally remove it (during a refactor etc).

[xslim]

I have some problems with implementing testing. As I understood this is not a pure RSpec…

How should I test here thing like

build_settings['OTHER_CFLAGS'].should  include('-DNS_BLOCK_ASSERTIONS=1')

?

[alloy]

Indeed. With Bacon the matcher methods are on the ‘should’ object. So in this case:

build_settings['OTHER_CFLAGS'].should.include('-DNS_BLOCK_ASSERTIONS=1')

[alloy]

And to check that an object is not included:

build_settings['OTHER_CFLAGS'].should.not.include('-DNS_BLOCK_ASSERTIONS=1')

[xslim]

oh, but how do I run the tests properly?
rspec --tag focus spec/project_spec.rb seems not working

[xslim]

ok, got it bacon spec/project_spec.rb

So I pushed tests..

[alloy]

Awesome, thanks!

I will merge this later today (I have to check if we should run this test for :osx as well) and do a release.

[alloy]

@irrationalfab Are the other commits you’ve added since 0.4.3 ready for release?

[alloy]

I’ll release a new gem tomorrow.

[fabiopelosin]

@alloy I've added a some minor stuff which includes minor changes in the API, so I think that we should release 0.5. If you release 0.5 please remove these lines.

[alloy]

Released.

[tsafrir]

@xslim When a .Podspec (like 'zipzap') defines value for OTHER_CPLUSPLUSFLAGS it will be ignored.
Should there be $(inherited) before NS_BLOCK_ASSERTIONS=1 ?
(The same probably goes for OTHER_CFLAGS)

[xslim]

interesting idea - needs checking...