[Lib] Fix $CHILD_STATUS on Ruby 1.8.7

Closes #28 Closes CocoaPods/CocoaPods#2225
CocoaPods · Aug 14, 2014 · 012d854 · 012d854
1 parent 298936d
commit 012d854
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,12 @@
   [Fabio Pelosin](https://github.com/irrationalfab)
   [#12](https://github.com/CocoaPods/cocoapods-downloader/issues/28)
 
+###### Bug Fixes
+
+* Fixed the check for git references on Ruby 1.8.7.  
+  [Fabio Pelosin](https://github.com/irrationalfab)
+  [#28](https://github.com/CocoaPods/cocoapods-downloader/issues/28)
+
 
 ## 0.6.1
 

diff --git a/lib/cocoapods-downloader.rb b/lib/cocoapods-downloader.rb
@@ -3,7 +3,9 @@ module Downloader
     if RUBY_VERSION >= '1.9.3'
       require 'English'
     else
-      alias $CHILD_STATUS $CHILD_STATUS
+      # rubocop:disable Style/SpecialGlobalVars
+      alias $CHILD_STATUS $?
+      # rubocop:enable Style/SpecialGlobalVars
     end
 
     require 'cocoapods-downloader/gem_version'

diff --git a/lib/cocoapods-downloader/git.rb b/lib/cocoapods-downloader/git.rb
@@ -139,7 +139,7 @@ def shallow_flags
       def ref_exists?(ref)
         if cache_exists?
           Dir.chdir(cache_path) { git "rev-list --max-count=1 #{ref}" }
-          $CHILD_STATUS == 0
+          $CHILD_STATUS.to_i == 0
         else
           false
         end
@@ -160,7 +160,7 @@ def ensure_ref_exists(ref)
       #
       def branch_exists?(branch)
         Dir.chdir(cache_path) { git "branch --all | grep #{branch}$" } # check for remote branch and do suffix matching ($ anchor)
-        $CHILD_STATUS == 0
+        $CHILD_STATUS.to_i == 0
       end
 
       # @return [void] Checks if a branch exists in the cache and updates