Skip to content

Commit

Permalink
[Http] fixed User-Agent format (removed semicolon). Fixed Changelog e…
Browse files Browse the repository at this point in the history
…ntry
  • Loading branch information
seanreinhardtapps committed Apr 11, 2020
1 parent 4b7703b commit 66ee297
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

##### Enhancements

* Add User-Agent to `cURL` requests when downloading source via the `:http` download strategy, unless one was provided by the `:headers` option.
* Add User-Agent to `cURL` requests when downloading source via the `:http` download strategy, unless one was provided by the `:headers` option.
[Sean Reinhardt](https://github.com/seanreinhardtapps)
[#9619](https://github.com/CocoaPods/CocoaPods/issues/9619)

Expand Down
2 changes: 1 addition & 1 deletion lib/cocoapods-downloader/base.rb
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ def checkout_options
# @return [String] the User-Agent string.
#
def self.user_agent_string(base_module = Pod)
pods_version = base_module.const_defined?("VERSION") ? "CocoaPods/#{base_module::VERSION};" : ''
pods_version = base_module.const_defined?("VERSION") ? "CocoaPods/#{base_module::VERSION} " : ''
"#{pods_version}cocoapods-downloader/#{Pod::Downloader::VERSION}"
end

Expand Down
2 changes: 1 addition & 1 deletion spec/base_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ module TestModuleNoVersion
module TestModuleWithVersion
VERSION = 'a.b.c'.freeze
end
Base.user_agent_string(TestModuleWithVersion).should == "CocoaPods/#{TestModuleWithVersion::VERSION};cocoapods-downloader/#{Pod::Downloader::VERSION}"
Base.user_agent_string(TestModuleWithVersion).should == "CocoaPods/#{TestModuleWithVersion::VERSION} cocoapods-downloader/#{Pod::Downloader::VERSION}"
end
end
end
Expand Down

0 comments on commit 66ee297

Please sign in to comment.