Skip to content

Commit

Permalink
Test coverage for filepaths with spaces
Browse files Browse the repository at this point in the history
  • Loading branch information
lazerwalker committed Dec 5, 2013
1 parent d0884c2 commit f4248d1
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion spec/cocoapods-downloaders/bazaar_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ module Downloader
tmp_folder('README').read.strip.should == 'Fourth Commit'
end

describe "when the directory name has quotes" do
describe "when the directory name has quotes or spaces" do
it 'checks out the head revision' do
options = { :bzr => fixture('bazaar-repo') }
downloader = Downloader.for_target(tmp_folder_with_quotes, options)
Expand Down
2 changes: 1 addition & 1 deletion spec/cocoapods-downloaders/git_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ module Downloader
end


it "checks out when the path contains quotes" do
it "checks out when the path contains quotes or spaces" do
options = { :git => fixture('git-repo'), :commit => '7ad3a6c' }
downloader = Downloader.for_target(tmp_folder_with_quotes, options)
downloader.download
Expand Down
2 changes: 1 addition & 1 deletion spec/cocoapods-downloaders/http_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ module Downloader
tmp_folder('GoogleAdMobSearchAdsSDK/GADSearchRequest.h').read.strip.should =~ /Google Search Ads iOS SDK/
end

it 'should download file and unzip it when the target folder name contains quotes' do
it 'should download file and unzip it when the target folder name contains quotes or spaces' do
options = { :http => 'http://dl.google.com/googleadmobadssdk/googleadmobsearchadssdkios.zip' }
downloader = Downloader.for_target(tmp_folder_with_quotes, options)
VCR.use_cassette('tarballs', :record => :new_episodes) { downloader.download }
Expand Down
2 changes: 1 addition & 1 deletion spec/cocoapods-downloaders/mercurial_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ module Downloader
tmp_folder('README').read.strip.should == 'second commit'
end

describe "when the directory name has quotes" do
describe "when the directory name has quotes or spaces" do
it "checks out a specific revision" do
options = { :hg => fixture('mercurial-repo'), :revision => '46198bb3af96' }
downloader = Downloader.for_target(tmp_folder_with_quotes, options)
Expand Down
2 changes: 1 addition & 1 deletion spec/cocoapods-downloaders/subversion_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ module Downloader
tmp_folder('README').read.strip.should == 'unintersting'
end

describe "when the directory name has quotes" do
describe "when the directory name has quotes or spaces" do
it "checks out a specific revision" do
options = { :svn => "file://#{fixture('subversion-repo')}", :revision => '1' }
downloader = Downloader.for_target(tmp_folder_with_quotes, options)
Expand Down
2 changes: 1 addition & 1 deletion spec/spec_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ def tmp_folder(path = '')
end

def tmp_folder_with_quotes(path = '')
return tmp_folder File.join("a'\"b", path)
return tmp_folder File.join("a' \"b", path)
end

def fixture(path)
Expand Down

0 comments on commit f4248d1

Please sign in to comment.