Added :tag and :branch options to mercurial downloader #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me... can you add an entry to the changelog and tests to verify the added functionality? |
|
@irrationalfab Apologies for requesting a pull without tests. |
|
Thanks for the specs... they look good. For the changelog just use master (The version will be set on release). Btw, nothing to apologise and thank you for the contribution 🍻 |
|
Changelog added. It should be good to go. Is there an ETA on when this changesets will belong to cocoapods main release? |
fabiopelosin
added a commit
that referenced
this pull request
Apr 14, 2014
Added :tag and :branch options to mercurial downloader
|
Awesome thanks! The ETA 1/2d (no promises though). 🍻 |
This was referenced Apr 14, 2014
|
Great, thanks very much for the quick responses! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following pull request closes:
Issue #16: Add
:tagoption to mercurial downloaderIssue #17: Add
:branchoption to mercurial downloader