Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added AWS S3 Event Source #632

Merged

Conversation

jongreenwood-dunelm
Copy link
Contributor

@jongreenwood-dunelm jongreenwood-dunelm commented Feb 7, 2023

Until now there is no defined AWS S3 Event Source and the event defaults to LAMBDA EDGE.

This PR adds AWS_S3 as an EventSource type and exports the request response mapper.

It allows invocation like this

`` `
const handler = serverlessExpress({
app: service(),
eventSourceRoutes: {
AWS_S3: '/s3',
},
eventSource: {
getRequest: getRequestValuesFromS3,
getResponse: getResponseToS3,
},
eventSourceName: 'AWS_S3',
logSettings: {
level: 'debug',
},
})


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@brettstack
Copy link
Collaborator

Hi @jongreenwood-dunelm I'd love to merge this but it's missing tests. Would you be able to add?

@brettstack brettstack merged commit 1132c1a into CodeGenieApp:mainline Dec 14, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants