docs: fix typos #5989
Merged
docs: fix typos #5989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lioness100
requested review from
Jackenmen,
TrustyJAID,
palmtree5,
aikaterna and
PredaaA
as code owners
github-actions
bot
added
Category: Cogs - Audio
Flame442
requested changes
Feb 14, 2023
| @@ -154,7 +154,7 @@ async def triviaset_allowoverride(self, ctx: commands.Context, enabled: bool): | |||
| ) | |||
|
|
|||
| @triviaset.command(name="usespoilers", usage="<true_or_false>") | |||
| async def trivaset_use_spoilers(self, ctx: commands.Context, enabled: bool): | |||
There was a problem hiding this comment.
All changes in this file are inaccurate, as the command name is the literal triviaset, standing for "trivia setting".
There was a problem hiding this comment.
I'm sorry, I think my intent was correct but I didn't fix it correctly. The typo was that it's "trivaset" (missing the "i" after the "v"). The problem was that I only fixed the trivia typo and forgot to add "set" with it.
There was a problem hiding this comment.
Ah, yep I see that now. If you want to make that change but keep set in the command name, that would be fine!
Flame442
added
the
Type: Bug
Co-authored-by: Flame442 <[email protected]>
red-githubbot
bot
added
the
Changelog Entry: Pending
|
Np! Just as a note, do you know if "bumpped_shuffle" is a typo? |
|
Sorry, @Jackenmen, I could not cleanly backport this to |
Jackenmen
pushed a commit
to Jackenmen/Red-DiscordBot
that referenced
this pull request
Apr 19, 2023
(cherry picked from commit a89a27c) Co-authored-by: Lioness100 <[email protected]> Co-authored-by: Flame442 <[email protected]>
Jackenmen
added a commit
that referenced
this pull request
Apr 19, 2023
Co-authored-by: Lioness100 <[email protected]> Co-authored-by: Flame442 <[email protected]>
Jackenmen
added
Changelog Entry: Added
Jackenmen
pushed a commit
to Jackenmen/Red-DiscordBot
that referenced
this pull request
May 5, 2023
Co-authored-by: Flame442 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
This PR fixes a few random typos (this was a trial run for a CLI I made)
I think "bumpped_shuffle" is a typo, but it was used in a lot of places in the code, so I didn't want to change anything without clearing it with a maintainer.
Also, I know this edits both code and comments, and modifies a lot of different sections of the code, so let me know if you need me to split it up into more modular PRs. :)
Have the changes in this PR been tested?
No