Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show only billable clients and projects #3441

Open
Shivam-Samant opened this issue Mar 2, 2024 · 2 comments
Open

Show only billable clients and projects #3441

Shivam-Samant opened this issue Mar 2, 2024 · 2 comments
Assignees

Comments

@Shivam-Samant
Copy link
Contributor

Shivam-Samant commented Mar 2, 2024

Summary of Feature Request:
In the invoice creating and listing screen billable and non-billable clients/projects are shown, but in that non-billable clients/projects are not used so needed to remove those unnecessary details as they are not utilized in those contexts.

Proposed Solution

  • When creating a project, add a new project type called non-billable and use that to hide all the non-billable projects in the invoice creation and listing screen.
  • Create the is_billable column to determine the billable and non-billable clients, and using that hide all the non-billable clients from the invoice creation and listing screen.

Approach

  • Add the Non Billable project type in the create/edit project screen.
  • Create migration to add the is_billable column in the clients table and make the default value true.
  • Add the checkbox for the is_billable column in the create/edit client screen.
  • Use the non-billable project type to hide the non-billable projects in the invoice create/edit screen.
  • Use the is_billable column of the clients table to only show the billable clients in the invoice create/edit screen.
@Shivam-Samant Shivam-Samant self-assigned this Mar 2, 2024
@P4NK4J
Copy link
Member

P4NK4J commented Mar 3, 2024

@Shivam-Samant The requirements are fine, just one question, there might be clients for whom we have nonbillable projects as well. We need to hide all the nonbillable projects from the invoice screen if a client is billable.
If a client is not billable, then it should not be displayed at all. Let me know if this would be addressed here as well.

@Shivam-Samant
Copy link
Contributor Author

@Shivam-Samant The requirements are fine, just one question, there might be clients for whom we have nonbillable projects as well. We need to hide all the nonbillable projects from the invoice screen if a client is billable. If a client is not billable, then it should not be displayed at all. Let me know if this would be addressed here as well.

Yes, so if the client is billable or partially billable then we mark that client as billable but in case of the partially billable client, the system will hide its non billable projects.

P4NK4J added a commit that referenced this issue Mar 5, 2024
#3441 - Hide non-billable projects and clients
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants