Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3431/Display Invoice Changes and Percentages in Invoice Screen #3432

Merged
merged 5 commits into from
Feb 28, 2024

Conversation

Abhinegi2
Copy link
Member

@Abhinegi2 Abhinegi2 commented Feb 28, 2024

Targets #3431

Description of the changes

Previously, the Invoice screen only displayed the total amount for each month, lacking crucial information about changes in the invoice amounts for each project compared to the last invoice. Additionally, there was no direct link for easy navigation to the revenue details for each client.

  • Introduced a feature that calculates and displays the amount difference for each project between the current invoice and the last one.
  • Implemented a percentage difference calculation for each project, providing users with a clear percentage representation of how much the invoice amount has changed.
  • Added hyperlinks (href) for each client displayed in the Invoice screen.

Breakdown & Estimates

  • Create a function to get the last month's Invoice details for each client: 3 - 4 hours
  • Create a function to get the difference of invoice for MoM: 3 - 4 hours
  • Add a field to show Invoice differences and percentages in the Invoice Listing: 3 - 4 hours
  • Implement Logic to change the color of the Amount difference for Increase and decrease of invoice: 3-4 hours
  • Added href link to easily navigate to revenue by client page: 1-2 hours

Feedback Cycle

Cycle Count: 0

Checklist:

  • The PR title follows this syntax: <#IssueID> <PR Title>
  • I have linked the issue id in the PR description.
  • I have performed a self-review of my own code.
  • I have added comments on my code changes where required.

@Abhinegi2 Abhinegi2 added the status : ready for review Items that are ready for code review label Feb 28, 2024
@Abhinegi2 Abhinegi2 self-assigned this Feb 28, 2024
Copy link
Contributor

github-actions bot commented Feb 28, 2024

Coverage report for commit: 97f8f58
File: coverage.xml

Cover ┌─────────────────────────┐ Freq.
   0% │ ███████████████████████ │ 82.5%
  10% │ █░░░░░░░░░░░░░░░░░░░░░░ │  1.8%
  20% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  30% │ █░░░░░░░░░░░░░░░░░░░░░░ │  0.9%
  40% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  50% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  60% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  70% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  80% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  90% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
 100% │ █████░░░░░░░░░░░░░░░░░░ │ 14.9%
      └─────────────────────────┘
 *Legend:* █ = Current Distribution 
Summary - Lines: 3.00% | Methods: 5.22%
FilesLinesMethodsBranches
app/Casts
   Decrypted.php--100.00%
app/Console/Commands
   CheckCommand.php--100.00%
   FakeProdDataCommand.php2.00%11.11%100.00%
   Setup.php--100.00%
app/Console
   Kernel.php12.50%50.00%100.00%
app/Exceptions
   Handler.php--100.00%
app/Helpers
   ContentHelper.php--100.00%
   DateHelper.php--100.00%
   DecimalToWordsHelper.php--100.00%
   FileHelper.php--100.00%
app/Http/Controllers/Auth
   ForgotPasswordController.php--100.00%
   LoginController.php--100.00%
   RegisterController.php--100.00%
   ResetPasswordController.php--100.00%
app/Http/Controllers/CRM
   CRMController.php--100.00%
app/Http/Controllers
   ClientController.php--100.00%
   CommentController.php--100.00%
   Controller.php100.00%100.00%100.00%
   HomeController.php26.47%50.00%100.00%
   ProjectController.php--100.00%
   ProjectStageController.php--100.00%
   UserBookController.php--100.00%
   UserController.php--100.00%
app/Http/Controllers/Finance
   InvoiceController.php--100.00%
   PaymentController.php--100.00%
   ReportsController.php--100.00%
app/Http/Controllers/HR/Applications
   VolunteerApplicationController.php--100.00%
app/Http/Controllers/HR/Volunteers
   CampaignsController.php--100.00%
   ReportsController.php--100.00%
   VolunteerOpportunityController.php--100.00%
app/Http/Controllers/KnowledgeCafe
   KnowledgeCafeController.php--100.00%
   WeeklyDoseController.php--100.00%
app/Http/Controllers/KnowledgeCafe/Library
   BookCategoryController.php--100.00%
   BookCommentController.php--100.00%
   BookController.php--100.00%
app/Http/Controllers/Settings
   BankDetailController.php--100.00%
   HRController.php--100.00%
   NDAAgreementController.php--100.00%
   PermissionController.php--100.00%
   SettingController.php--100.00%
app/Http
   Kernel.php100.00%100.00%100.00%
app/Http/Middleware
   EncryptCookies.php100.00%100.00%100.00%
   RedirectIfAuthenticated.php--100.00%
   TrimStrings.php100.00%100.00%100.00%
   TrustProxies.php100.00%100.00%100.00%
   VerifyCsrfToken.php100.00%100.00%100.00%
app/Http/Requests
   ClientRequest.php--100.00%
   ProjectRequest.php--100.00%
   ProjectStageRequest.php--100.00%
app/Http/Requests/Finance
   InvoiceRequest.php--100.00%
   PaymentRequest.php--100.00%
app/Http/Requests/KnowledgeCafe/Library
   BookCategoryRequest.php--100.00%
   BookRequest.php--100.00%
app/Http/Requests/KnowledgeCafe
   WeeklyDoseRequest.php--100.00%
app/Http/Requests/Setting
   SettingRequest.php--100.00%
   UpdateRolePermissionsRequest.php--100.00%
   UpdateUserRolesRequest.php--100.00%
app/Http/View/Composers
   CodeTrekApplicantsComposer.php100.00%100.00%100.00%
app/Imports
   ApplicationImport.php--100.00%
app/Listeners
   RemoveUserFromWebsite.php--100.00%
app/Mail
   DailyEffortSummary.php--100.00%
   ErrorReport.php--100.00%
   sendEmail.php--100.00%
app/Models
   BankDetails.php100.00%100.00%100.00%
   Category.php--100.00%
   Client.php--100.00%
   ClientCrmDetails.php--100.00%
   Comment.php--100.00%
   Country.php100.00%100.00%100.00%
   Project.php--100.00%
   ProjectStage.php--100.00%
   ProjectStageBilling.php--100.00%
   Resource.php--100.00%
   Setting.php--100.00%
   SkillSet.php100.00%100.00%100.00%
   Tag.php--100.00%
app/Models/Finance
   Invoice.php--100.00%
   Payment.php--100.00%
app/Models/Finance/PaymentModes
   Cash.php--100.00%
   Cheque.php--100.00%
   WireTransfer.php--100.00%
app/Models/KnowledgeCafe/Library
   Book.php13.79%13.64%100.00%
   BookAMonth.php--100.00%
   BookCategory.php--100.00%
app/Models/KnowledgeCafe
   WeeklyDose.php100.00%100.00%100.00%
app/Notifications
   ReviewNDA.php--100.00%
app/Policies
   ClientPolicy.php--100.00%
   ProjectPolicy.php--100.00%
   SettingPolicy.php--100.00%
   UserPolicy.php--100.00%
app/Policies/Finance
   InvoicePolicy.php--100.00%
   ReportPolicy.php--100.00%
app/Policies/Infrastructure
   BillingsPolicy.php--100.00%
app/Policies/KnowledgeCafe/Library
   BookCategoryPolicy.php--100.00%
   BookPolicy.php--100.00%
app/Policies/KnowledgeCafe
   WeeklyDosePolicy.php--100.00%
app/Providers
   AppServiceProvider.php100.00%100.00%100.00%
   ApplicantsComposerServiceProvider.php100.00%100.00%100.00%
   AuthServiceProvider.php100.00%100.00%100.00%
   BroadcastServiceProvider.php--100.00%
   DatabaseServiceProvider.php100.00%100.00%100.00%
   EventServiceProvider.php100.00%100.00%100.00%
   RouteServiceProvider.php100.00%100.00%100.00%
app/Rules
   TeamMemberDesignationRule.php--100.00%
   TeamMemberRule.php--100.00%
app/Services
   BookServices.php--100.00%
   CRMServices.php--100.00%
   CalendarEventService.php--100.00%
   EmployeeService.php--100.00%
   GSuiteUserService.php--100.00%
   WebsiteUserService.php--100.00%
app/Traits
   Encryptable.php--100.00%
   Filters.php--100.00%
   HasTags.php--100.00%

🤖 comment via lucassabreu/comment-coverage-clover

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 3.38%. Comparing base (35dcd24) to head (97f8f58).

Additional details and impacted files
@@           Coverage Diff            @@
##             master   #3432   +/-   ##
========================================
  Coverage      3.38%   3.38%           
  Complexity      584     584           
========================================
  Files           103     103           
  Lines          2065    2065           
========================================
  Hits             70      70           
  Misses         1995    1995           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Feb 28, 2024

Passing run #7950 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge 97f8f58 into 35dcd24...
Project: Employee portal Commit: 3df23ff9a4 ℹ️
Status: Passed Duration: 00:30 💡
Started: Feb 28, 2024 6:15 AM Ended: Feb 28, 2024 6:15 AM

Review all test suite changes for PR #3432 ↗︎

@Abhinegi2 Abhinegi2 requested a review from P4NK4J February 28, 2024 07:44
@P4NK4J P4NK4J merged commit a725a09 into master Feb 28, 2024
8 checks passed
@P4NK4J P4NK4J deleted the feature/added-billing-amount-changes-in-invocie-page branch February 28, 2024 08:36
@cypress cypress bot mentioned this pull request Feb 28, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status : ready for review Items that are ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants