Saferpay's Transaction Logs in Admin Panel #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jakubtobiasz
commented
May 30, 2023
•
jakubtobiasz
commented
jakubtobiasz
force-pushed
the
feature/transaction-logs-in-ap
branch
2 times, most recently
from
cee8e17 to
c86084b
Compare
jakubtobiasz
force-pushed
the
feature/transaction-logs-in-ap
branch
from
c86084b to
033488b
Compare
Zales0123
approved these changes
Jun 5, 2023
| */ | ||
| public function iShouldSeeTheContextInformationAboutCommunicationWithSaferpay(): void | ||
| { | ||
| Assert::true($this->showPage->getContext() !== ''); |
There was a problem hiding this comment.
Lazy 😄 can we check it in more detail or there is no point we could determine them within the Behat scenario?
There was a problem hiding this comment.
I know it could be better, but not checking the whole context can always be called lazy :D. If I check whether there are only request and response keys, there is still a change they're empty. So, the only "good" way is checking the whole context, which is really long, and it might make only a little bit more sense.
|
Thank you, Jakub! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.