[Admin] Configure available Saferpay payment methods retrieved by the API #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zales0123
reviewed
Jun 5, 2023
.../payment/being_able_to_configure_available_payment_methods_only_for_saferpay_gateway.feature
Outdated
Show resolved
Hide resolved
| /** @var array $allowedPaymentMethods */ | ||
| $allowedPaymentMethods = $data['allowed_payment_methods']; | ||
|
|
||
| $this->commandBus->dispatch(new ConfigurePaymentMethods($paymentMethodId, $allowedPaymentMethods)); |
There was a problem hiding this comment.
I wonder if command pattern is not an overkill here 🤔 Cannot we just use a standard resource update action to partially update the payment method?
There was a problem hiding this comment.
I think you're right that this might be overkill, but at the same time I'm wondering if it makes sense to change it now as it's a bit of a big change, and I'm also not sure how to properly use the resource controller as it's quite a custom form type and updating one field in the gateway config array, even so not necessarily updating the resource 🤔
…payment method only
Zales0123
approved these changes
Jun 6, 2023
|
Thank you, Grzegorz! 🖖 |
Zales0123
deleted the
configure-available-payment-methods-from-saferpay-api
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Payment method index page:
Saferpay available payment methods configuration page:
