Fix cancelling payments #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zales0123
reviewed
Sep 12, 2023
Zales0123
approved these changes
Sep 14, 2023
|
Thank you, @GSadee! Let's test it out and 🤞 it will work properly in the real application 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix 2 issues:
payment cancellations, after which the user would get a success message even though the payment had been cancelled
overlapping of synchronous and webhook processing, which could lead to a situation where the payment remained with the
processingflag and there was no possibility to process it further, either to cancel it or to pay correctly.Now,
if synchronous processing starts first, the webhook will not be processed,
if the webhook starts first, synchronous processing will wait until the webhook finishes and then check the status of the last and penultimate payment