Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using "imp" module #10819

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Stop using "imp" module #10819

merged 1 commit into from
Jul 12, 2023

Conversation

jan-cerny
Copy link
Collaborator

Fixes broken build on Fedora Rawhide.

The deprecated importlib API has been removed from Python 3.12, see python/cpython#98040.

Addressing:

Traceback (most recent call last):
  File "/builddir/build/BUILD/scap-security-guide-0.1.69/build-scripts/build_templated_content.py", line 9, in <module>
    import ssg.templates
  File "/builddir/build/BUILD/scap-security-guide-0.1.69/ssg/templates.py", line 5, in <module>
    import imp
ModuleNotFoundError: No module named 'imp'

@jan-cerny
Stop using "imp" module
9fd541b 
Fixes broken build on Fedora Rawhide.

The deprecated importlib API has been removed from Python 3.12,
see python/cpython#98040.

Addressing:

Traceback (most recent call last):
  File "/builddir/build/BUILD/scap-security-guide-0.1.69/build-scripts/build_templated_content.py", line 9, in <module>
    import ssg.templates
  File "/builddir/build/BUILD/scap-security-guide-0.1.69/ssg/templates.py", line 5, in <module>
    import imp
ModuleNotFoundError: No module named 'imp'
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Jul 11, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jul 11, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jan-cerny jan-cerny added BLOCKER Impediments to release, like failure to build content, or content built is out of standard's syntax Infrastructure Our content build system and removed do-not-merge/work-in-progress Used by openshift-ci bot. labels Jul 11, 2023
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Jul 11, 2023

Code Climate has analyzed commit 9fd541b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 6.6% (50% is the threshold).

This pull request will bring the total coverage in the repository to 53.4% (-0.1% change).

View more on Code Climate.

@jan-cerny
Copy link
Collaborator Author

This fixed the broken Packit build. But it didn't fix the GH Actions build, where the problem is different.

@Mab879 Mab879 self-assigned this Jul 11, 2023
@Mab879
Copy link
Member

Mab879 commented Jul 11, 2023

This fixed the broken Packit build. But it didn't fix the GH Actions build, where the problem is different.

It appears that GH Actions job is broken due to numpy/numpy#23808.

@jan-cerny jan-cerny marked this pull request as ready for review July 12, 2023 08:01
@jan-cerny
Copy link
Collaborator Author

@Mab879 Thanks for the discovery! 👍

@jan-cerny jan-cerny added this to the 0.1.69 milestone Jul 12, 2023
Mab879
Mab879 approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built all products and ran ctests for them and they ran as expected.

@Mab879 Mab879 merged commit ccd4ca5 into ComplianceAsCode:master Jul 12, 2023
@marcusburghardt marcusburghardt mentioned this pull request Sep 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mab879 Mab879 Mab879 approved these changes

Assignees

@Mab879 Mab879

Labels
BLOCKER Impediments to release, like failure to build content, or content built is out of standard's syntax Infrastructure Our content build system
Projects
None yet
Milestone
0.1.69
Development

Successfully merging this pull request may close these issues.
2 participants
@jan-cerny @Mab879