solana-ibc: get host consensus state based on feature #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mina86
approved these changes
Oct 18, 2024
solana/solana-ibc/programs/solana-ibc/src/validation_context.rs
Outdated
Show resolved
Hide resolved
solana/solana-ibc/programs/solana-ibc/src/validation_context.rs
Outdated
Show resolved
Hide resolved
solana/solana-ibc/programs/solana-ibc/src/validation_context.rs
Outdated
Show resolved
Hide resolved
solana/solana-ibc/programs/solana-ibc/src/validation_context.rs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Host consensus state is required for establishing the connection. So the host consensus state should be returned based on whether the
witnessfeature is present or not. If the feature is present, then we return the rollup consensus state else we return the guest consensus state. But the issue is if thewitnessfeature is not enabled, it could either be guest or wasm ( which is a wrapper version of guest ). Since the connection with cosmos is already established, we would stick to returning theguestconsensus state for now.