Update Interchain-test and lint #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
anhductn2001
commented
Jul 20, 2023
•
anhductn2001
commented
- Update new Image of Centaurid and Polkadot for CI working.
- Fix some warning by Go-Lint
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if err != nil { | ||
| // If the ack is not a json object, error | ||
| return err | ||
| } | ||
|
|
||
| sudoMsg := []byte(fmt.Sprintf( | ||
| `{"ibc_lifecycle_complete": {"ibc_ack": {"channel": "%s", "sequence": %d, "ack": %s, "success": %s}}}`, | ||
| packet.SourceChannel, packet.Sequence, ackAsJson, success)) | ||
| packet.SourceChannel, packet.Sequence, ackAsJSON, success)) |
Check failure
Code scanning / CodeQL
Potentially unsafe quoting
|
Please leave a description on all PR's |
tungleanh0902
pushed a commit
to notional-labs/composable-cosmos
that referenced
this pull request
Mar 7, 2024
Update Interchain-test and lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.