Introduce custom staking module that update validators voting power each N blocks

[RustNinja]

2 modules introduced:

• custom staking module that actually override logic of cosmos staking.
• staking middleware that store params how often update voting power for validators

BlockValidatorUpdates
method taken from cosmosSDK/x/staking module
and if line introduced that basically now execute ApplyAndReturnValidatorSetUpdates each N blocks

if shouldExecuteBatch {
        v, err := k.ApplyAndReturnValidatorSetUpdates(ctx)
        if err != nil {
	        panic(err)
        }
        validatorUpdates = v
}

[joe-bowman]

An aside and perhaps for another time:

Why is the custom staking module in custom/staking and not under x/staking or x/customstaking?

[RustNinja]

An aside and perhaps for another time:

Why is the custom staking module in custom/staking and not under x/staking or x/customstaking?

thanks for question sir.
the reason why custom/staking is not under /x bz of the same reason that custom/bank is not under /x
custom staking it is just a wrapper around cosmos staking that does not have any storage, not any changes in query or tx service. so imo it should be in /custom folder because custom bask is there as well.

[RustNinja]

Looks good for the most part.

I don't understand the point of the stakingmiddleware - it appears to exist to manage params only, which are then consumed by the custom staking module. Why are the params not part of the custom staking module?

Otherwise, many references in comments to 'mint' from presumably using mint module as the template. Should be updated to reflect reality.

thanks. initially this module was created to collect all staking bond/unbond request from users and execute them later each N block in EndBlock. but later we changed the approach to execute initial staking End block validator set update each N block. so i would like to keep this logic with storing params separately to not introduce extra storage key into the initial staking module and not introduce any changes into tx/query service into cosmos staking module that not represented as wrapper module custom-staking.

[joe-bowman]

An aside and perhaps for another time:
Why is the custom staking module in custom/staking and not under x/staking or x/customstaking?

thanks for question sir. the reason why custom/staking is not under /x bz of the same reason that custom/bank is not under /x custom staking it is just a wrapper around cosmos staking that does not have any storage, not any changes in query or tx service. so imo it should be in /custom folder because custom bask is there as well.

I'd argue that all your modules in x/ are 'custom', and both bank and staking ought to be in x/, but it's a personal preference thing :)

[RustNinja]

update:
Tested with @rjonczy on devnet with a 2 validators
worked as expected:

• unbond
• validator set did not changed immediately
• validator set voting power changed later on block X that % N without rest

cc @blasrodri @JafarAz

[blasrodri]

If @faddat and @joe-bowman are happy we merge

[faddat]

@blasrodri I think we may need to rebase this on v7 but I agree with you on readiness, pending addressing Joe's questions.

[joe-bowman]

lgtm.