Make enabling SCIM it's own flag instead of deduced from the status of scim-endpoint and scim-token #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f scim-endpoint and scim-token, like the other features are
loganintech
changed the title
notanthony
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The other features
SSO,Orgs, andUseAssumeRoleuse separate flags to determine if the feature is enabled. #21 adds SCIM as an optional feature. This PR updates the instantiation of the connector such that it follows the same--FEATURE-enabledpattern that the others do, instead of enabling it based on the values of its dependent config variables.