Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix source params #71

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Fix source params #71

merged 1 commit into from
Jul 30, 2024

Conversation

hariso
Copy link
Contributor

@hariso hariso commented Jul 29, 2024 •
edited
Loading

Description

Parameters should be provided through NewSource(), because it includes the middleware configuration parameters.

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@hariso hariso requested a review from a team as a code owner July 29, 2024 15:06
@lovromazgon lovromazgon merged commit 65a437b into main Jul 30, 2024
3 checks passed
@lovromazgon lovromazgon deleted the haris/fix-params branch July 30, 2024 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovromazgon lovromazgon lovromazgon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hariso @lovromazgon