Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding acceptance test for S3 #44

Closed
wants to merge 2 commits into from
Closed

adding acceptance test for S3 #44

wants to merge 2 commits into from

Conversation

maha-hajja
Copy link
Contributor

Description

A lot of methods are copied from the source tests, just to create and delete new buckets

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@maha-hajja maha-hajja requested a review from a team as a code owner May 6, 2022 14:51
@maha-hajja maha-hajja marked this pull request as draft May 6, 2022 14:52
@hariso
Copy link
Contributor

hariso commented May 9, 2022

@maha-hajja I see that a review was request but the PR is still a draft. Is that intended?

@maha-hajja
Copy link
Contributor Author

@hariso the review was requested automatically before I converted it to a draft! So no it's still not ready for review.

@maha-hajja maha-hajja closed this Jun 15, 2022
@maha-hajja maha-hajja mentioned this pull request Jun 15, 2022
Open
@lovromazgon lovromazgon deleted the maha/acceptance-test branch August 7, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maha-hajja @hariso @lovromazgon