make more things internal and switch some stuff to use IEphemeralMeta…

…data over the concrete

src/Ephemerally.Azure.Cosmos/InternalExtensions.cs

@@ -5,6 +5,9 @@ namespace Ephemerally.Azure.Cosmos;
 
 internal static class InternalExtensions
 {
+    internal static T OrDefault<T>(this T options) where T : EphemeralOptions, new() =>
+        options ?? new T();
+
     internal static async Task<bool> ExistsAsync(this Database database) =>
         await database.Client.DatabaseExistsAsync(database.Id).ConfigureAwait(false);
 

src/Ephemerally.Azure.Cosmos/PublicExtensions.cs

@@ -33,15 +33,15 @@ public static async Task<EphemeralCosmosContainer> CreateEphemeralContainerAsync
         return database.GetContainer(response.Resource.Id).ToEphemeral(options);
     }
 
-    public static EphemeralMetadata GetEphemeralMetadata(this DatabaseProperties container) =>
+    public static IEphemeralMetadata GetEphemeralMetadata(this DatabaseProperties container) =>
         container.Id.GetContainerMetadata();
 
-    public static EphemeralMetadata GetEphemeralMetadata(this Database container) =>
+    public static IEphemeralMetadata GetEphemeralMetadata(this Database container) =>
         container.Id.GetContainerMetadata();
 
-    public static EphemeralMetadata GetEphemeralMetadata(this ContainerProperties container) =>
+    public static IEphemeralMetadata GetEphemeralMetadata(this ContainerProperties container) =>
         container.Id.GetContainerMetadata();
 
-    public static EphemeralMetadata GetEphemeralMetadata(this Container container) =>
+    public static IEphemeralMetadata GetEphemeralMetadata(this Container container) =>
         container.Id.GetContainerMetadata();
 }

src/Ephemerally/InternalExtensions.cs

@@ -0,0 +1,13 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+using System.Threading.Tasks;
+
+namespace Ephemerally;
+
+internal static class InternalExtensions
+{
+    internal static T OrDefault<T>(this T options) where T : EphemeralOptions, new() =>
+        options ?? new T();
+}

src/Ephemerally/PublicExtensions.cs

@@ -2,21 +2,15 @@
 
 public static class PublicExtensions
 {
-    //public static EphemeralCreationOptions OrDefault(this EphemeralCreationOptions options) =>
-    //    options ?? EphemeralCreationOptions.Default;
-
-    public static T OrDefault<T>(this T options) where T : EphemeralOptions, new() =>
-        options ?? new T();
-
-    public static EphemeralMetadata GetNewMetadata(this EphemeralCreationOptions options) =>
+    public static IEphemeralMetadata GetNewMetadata(this EphemeralCreationOptions options) =>
         EphemeralMetadata.New(options.Name, options.GetExpiration(DateTimeOffset.UtcNow));
 
-    public static bool IsExpired(this EphemeralMetadata metadata) =>
-        IsExpired(metadata, DateTimeOffset.UtcNow);
+    public static bool IsExpired(this IEphemeralMetadata metadata) =>
+        IsExpiredAsOf(metadata, DateTimeOffset.UtcNow);
 
-    internal static bool IsExpired(this EphemeralMetadata metadata, DateTimeOffset now) =>
+    public static bool IsExpiredAsOf(this IEphemeralMetadata metadata, DateTimeOffset now) =>
         metadata.Expiration.HasValue && metadata.Expiration.Value <= now;
 
-    public static EphemeralMetadata GetContainerMetadata(this string fullName) =>
+    public static IEphemeralMetadata GetContainerMetadata(this string fullName) =>
         EphemeralMetadata.New(fullName);
 }

tests/Ephemerally.Tests/EphemeralMetadataTests.cs

@@ -18,6 +18,6 @@ public bool IsExpired_as_of_1684991963(long now)
             Nonce = "ABCDEF"
         };
 
-        return metadata.IsExpired(DateTimeOffset.FromUnixTimeSeconds(now));
+        return metadata.IsExpiredAsOf(DateTimeOffset.FromUnixTimeSeconds(now));
     }
 }