Improvements

- Hide mounted volume from applications such as Finder - Force unmount dmg when installation is finished
Conky-for-macOS · Mar 25, 2018 · f887353 · f887353
1 parent 421d441
commit f887353
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/Manage Conky/ConkyInstallerSheetController.m b/Manage Conky/ConkyInstallerSheetController.m
@@ -145,8 +145,10 @@ - (void)beginInstalling
     /*
      * detect if XQuartz is installed
      */
-    if (access(XQUARTZ_PATH, F_OK) == 0)
+    if (access(XQUARTZ_PATH, F_OK) != 0)
     {
+        [self writeToLog:@"XQuartz is missing, downloading...\n\n"];
+
         //
         // Must start the Helper
         //

diff --git a/Manage Conky/Resources/InstallXQuartz.sh b/Manage Conky/Resources/InstallXQuartz.sh
@@ -14,13 +14,14 @@
 curl -L -s -o /tmp/XQuartz.dmg https://dl.bintray.com/xquartz/downloads/XQuartz-2.7.11.dmg
 
 # mount dmg
-hdiutil attach /tmp/XQuartz.dmg -mountpoint /Volumes/XQuartz
+# (make it invisible to Finder)
+hdiutil attach /tmp/XQuartz.dmg -mountpoint /Volumes/XQuartz -nobrowse
 
 # run the intstaller
 installer -pkg /Volumes/XQuartz/XQuartz.pkg -target /
 
 # umnount
-hdiutil detach /Volumes/XQuartz
+hdiutil detach /Volumes/XQuartz -force
 
 # cleanup
 rm -f /tmp/XQuartz.dmg